Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing error handler #3859

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: missing error handler #3859

merged 1 commit into from
Nov 21, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 21, 2024

Super unlikely but technically possible...

@ronag ronag force-pushed the missing-onerror branch 2 times, most recently from 4730909 to e3133bf Compare November 21, 2024 15:11
mcollina
mcollina approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 6551919 into main Nov 21, 2024
42 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @mcollina